Refactoring: Separating HSM and Speed sends #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3063--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3063 +/- ##
=======================================
Coverage 81.86% 81.87%
=======================================
Files 326 327 +1
Lines 10506 10516 +10
Branches 2167 2170 +3
=======================================
+ Hits 8601 8610 +9
- Misses 1296 1297 +1
Partials 609 609 ☔ View full report in Codecov by Sentry. |
Glific
|
||||||||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
templates-refactoring
|
| Run status |
|
| Run duration | 28m 10s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
171
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/flow/FlowEditor.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Flow > should configure Flow |
Test Replay
Screenshots
|
|
…tend into templates-refactoring
kurund
requested changes
Nov 20, 2024
kurund
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.